Messages in this thread Patch in this message | | | From | "Eric W. Biederman" <> | Subject | [PATCH 14/15] sysfs: sysfs_setattr remove unnecessary permission check. | Date | Sat, 7 Nov 2009 23:27:12 -0800 |
| |
From: Eric W. Biederman <ebiederm@maxwell.aristanetworks.com>
inode_change_ok already clears the SGID bit when necessary so there is no reason for sysfs_setattr to carry code to do the same, and it is good to kill the extra copy because when I moved the code last in certain corner cases the code will look at the wrong gid.
Acked-by: Serge Hallyn <serue@us.ibm.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com> --- fs/sysfs/inode.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index 082a3eb..8197e1a 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c @@ -117,10 +117,6 @@ int sysfs_setattr(struct dentry * dentry, struct iattr * iattr) return error; iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */ - if (iattr->ia_valid & ATTR_MODE) { - if (!in_group_p(inode->i_gid) && !capable(CAP_FSETID)) - iattr->ia_mode &= ~S_ISGID; - } error = inode_setattr(inode, iattr); if (error) -- 1.6.5.2.143.g8cc62
| |