Messages in this thread | | | Date | Sun, 8 Nov 2009 07:45:14 -0800 | From | Jesse Barnes <> | Subject | Re: [PATCH, v3] x86: Adjust GFP mask handling for coherent allocations |
| |
On Sun, 8 Nov 2009 12:12:14 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> > * Takashi Iwai <tiwai@suse.de> wrote: > > > At Wed, 04 Nov 2009 12:28:39 +0000, > > Jan Beulich wrote: > > > > > > Rather than forcing GFP flags and DMA mask to be inconsistent, GFP > > > flags should be determined even for the fallback device through > > > dma_alloc_coherent_mask()/dma_alloc_coherent_gfp_flags(). This > > > restores 64-bit behavior as it was prior to commits > > > 8965eb19386fdf5ccd0ef8b02593eb8560aa3416 and > > > 4a367f3a9dbf2e7ffcee4702203479809236ee6e (not sure why there are > > > two of them), where GFP_DMA was forced on for 32-bit, but not for > > > 64-bit, with the slight adjustment that afaict even 32-bit > > > doesn't need this without CONFIG_ISA. > > > > > > Signed-off-by: Jan Beulich <jbeulich@novell.com> > > > Cc: Takashi Iwai <tiwai@suse.de> > > > > Acked-by: Takashi Iwai <tiwai@suse.de> > > Jesse, mind picking this up for .32? > > I've attached below a slightly cleaned up version of the patch, with > Takashi's ack added.
Sure, I just stuffed it into my for-linus tree, I'll send a pull req on Monday or Tuesday.
Thanks, -- Jesse Barnes, Intel Open Source Technology Center
| |