lkml.org 
[lkml]   [2009]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86, amd-ucode: Remove needless log messages

* Andreas Herrmann <herrmann.der.user@googlemail.com> wrote:

>
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> ---
> arch/x86/kernel/microcode_amd.c | 9 +--------
> 1 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
> index f4c538b..c043534 100644
> --- a/arch/x86/kernel/microcode_amd.c
> +++ b/arch/x86/kernel/microcode_amd.c
> @@ -185,9 +181,6 @@ get_next_ucode(const u8 *buf, unsigned int size, unsigned int *mc_size)
>
> total_size = (unsigned long) (section_hdr[4] + (section_hdr[5] << 8));
>
> - printk(KERN_DEBUG "microcode: size %u, total_size %u\n",
> - size, total_size);
> -

we should remove this one indeed.

> @@ -109,12 +109,8 @@ static int get_matching_microcode(int cpu, void *mc, int rev)
> return 0;
> }
>
> - if (mc_header->processor_rev_id != equiv_cpu_id) {
> - printk(KERN_ERR "microcode: CPU%d: patch mismatch "
> - "(processor_rev_id: %x, equiv_cpu_id: %x)\n",
> - cpu, mc_header->processor_rev_id, equiv_cpu_id);
> + if (mc_header->processor_rev_id != equiv_cpu_id)
> return 0;
> - }
>
> /* ucode might be chipset specific -- currently we don't support this */
> if (mc_header->nb_dev_id || mc_header->sb_dev_id) {

but why remove this one? Someone tries to load a mismatching microcode
file, isnt that some sort of bug in user-space? (Which ought to find out
whether it has anything for the CPU at hand, and only attempt it if it's
matching - or so.)

maybe it's not a KERN_ERR but KERN_INFO, but still.

Ingo


\
 
 \ /
  Last update: 2009-11-08 16:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site