Messages in this thread |  | | | Date | Sat, 7 Nov 2009 12:20:02 +0100 | | From | Haavard Skinnemoen <> | | Subject | Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and board |
Ben Nizette <bn@niasdigital.com> wrote: > On Tue, 2009-11-03 at 15:30 +1300, Ryan Mallon wrote: > > > > > IIRC, we can't mark static inline functions as weak, and we don't want > > to turn gpio_is_valid into an actual function call. We could do some > > preprocessor magic, but that gets a bit messy. > > Messy but generally accepted.
IIRC the most generally accepted way is to do
static inline bool gpio_is_valid(int pin) { /* whatever */ } #define gpio_is_valid gpio_is_valid in the platform code and
#ifndef gpio_is_valid /* provide definition of gpio_is_valid */ #endif in the generic code. This way, there's only one symbol to grep for.
Haavard
|  |