Messages in this thread |  | | | Date | Sat, 07 Nov 2009 11:27:03 +0100 | | From | Jiri Slaby <> | | Subject | Re: [PATCH -mm] char, moxa: Make isabrds variable global. |
| |
On 11/07/2009 06:08 AM, Rakib Mullick wrote: > On 11/3/09, Rakib Mullick <rakib.mullick@gmail.com> wrote: >> When CONFIG_MODULE=n and CONFIG_PCI=n, then variable >> isabrds becomes unused variable. So place it outside >> moxa_init solves this problem. >> >> We were warned by the following warning: >> >> drivers/char/moxa.c: In function `moxa_init': >> drivers/char/moxa.c:1012: warning: unused variable `isabrds' > > Hi Andrew, after applying this one, it introduce a new warning:
Sorry I had no time to look into the first patch. And it makes no sense. The driver is unusable on !MODULE && !PCI. So better fix is to disallow whole build on such configurations. Care to fix that?
|  |