| | Date | Sat, 07 Nov 2009 11:18:35 +0900 | | From | Tejun Heo <> | | Subject | Re: [PATCH 14/13] sysfs: sysfs_setattr remove unnecessary permission check. |
Eric W. Biederman wrote: > inode_change_ok already clears the SGID bit when necessary so there is > no reason for sysfs_setattr to carry code to do the same, and it is > good to kill the extra copy because when I moved the code, I goofed > and in certain corner cases the code will look at the wrong gid. > > Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Acked-by: Tejun Heo <tj@kernel.org>
I would much prefer this one being prior to 06 but if it's too painful, please at least note it in the description of 06.
Thanks.
-- tejun
|