lkml.org 
[lkml]   [2009]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH testing] Do not call IPv4 specific func in tcp_check_req
From
From: Gilad Ben-Yossef <gilad@codefidence.com>
Date: Wed, 4 Nov 2009 18:40:54 +0200

> Calling IPv4 specific inet_csk_route_req in tcp_check_req
> is a bad idea and crashes machine on IPv6 connections, as reported
> by Valdis Kletnieks
>
> Also, all we are really interested in is the timestamp
> option in the header, so calling tcp_parse_options()
> with the "estab" set to false flag is an overkill as
> it tries to parse half a dozen other TCP options.
>
> We know whether timestamp should be enabled or not
> using data from request_sock.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>

Applied, thanks.

I assume that your other patch which attempted to fix this isn't
necessary.


\
 
 \ /
  Last update: 2009-11-05 08:25    [W:0.195 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site