lkml.org 
[lkml]   [2009]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci/pcie: Avoid unnecessary PCIe link retrains
Matthew Wilcox wrote:
> On Thu, Nov 05, 2009 at 12:05:11PM +0900, Kenji Kaneshige wrote:
>> There are a lot of codes that searches PCI express capability offset
>> in the PCI configuration space using pci_find_capability(). Caching it
>> in the struct pci_dev will reduce unncecessary search. This patch adds
>> an additional 'pcie_cap' fields into struct pci_dev, which is
>> initialized at pci device scan time (in set_pcie_port_type()).
>
> I think adding this should imply the removal of ->is_pcie. pcie_cap == 0
> means !is_pcie.

Right.

But, as you know, we need to change users of is_pcie (including some
adapter card drivers) before removing it.

Thanks,
Kenji Kaneshige




\
 
 \ /
  Last update: 2009-11-06 03:51    [W:2.241 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site