Messages in this thread | | | Date | Thu, 5 Nov 2009 20:29:49 -0500 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH] softirq,tracing: enable to trace softirq raise latency |
| |
* Lai Jiangshan (laijs@cn.fujitsu.com) wrote: > Mathieu Desnoyers wrote: > > * Lai Jiangshan (laijs@cn.fujitsu.com) wrote: > >> +/** > >> * softirq_entry - called immediately before the softirq handler > >> * @h: pointer to struct softirq_action > >> * @vec: pointer to first struct softirq_action in softirq_vec array > > > > Please change this comment to "@vec: softirq vector number" while you > > are at it. The same probably needs to be done for softirq_exit. @vec are > > not pointers: these are offsets. > > > > Thank you for you like it and your comment. > > @vec are pointers here. it's softirq_vec. Don't need to change > these comments.
Ah, yes, you're right. I got confused by looking only at the patch context.
Thanks,
Mathieu
> > Lai
-- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |