lkml.org 
[lkml]   [2009]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] softirq,tracing: enable to trace softirq raise latency
* Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> Mathieu Desnoyers wrote:
> > * Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> >> +/**
> >> * softirq_entry - called immediately before the softirq handler
> >> * @h: pointer to struct softirq_action
> >> * @vec: pointer to first struct softirq_action in softirq_vec array
> >
> > Please change this comment to "@vec: softirq vector number" while you
> > are at it. The same probably needs to be done for softirq_exit. @vec are
> > not pointers: these are offsets.
> >
>
> Thank you for you like it and your comment.
>
> @vec are pointers here. it's softirq_vec. Don't need to change
> these comments.

Ah, yes, you're right. I got confused by looking only at the patch
context.

Thanks,

Mathieu

>
> Lai

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


\
 
 \ /
  Last update: 2009-11-06 02:37    [W:0.035 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site