lkml.org 
[lkml]   [2009]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 15/13] sysfs: Protect sysfs_refresh_inode with inode mutex.
    "Serge E. Hallyn" <serue@us.ibm.com> writes:

    > Quoting Eric W. Biederman (ebiederm@xmission.com):
    >>
    >> In general everything that writes to vfs inodes holds the
    >> inode mutex, so hold the inode mutex over sysfs_refresh_inode.
    >> The sysfs data structures don't need this but it looks like the
    >> vfs might.
    >>
    >> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
    >
    > Oh right so pls disregard my last reply to patch 9 :)

    I also checked and nfs has the same basic structure and does take the
    inode mutex on these paths, inside of nfs_refresh_inode which is
    called from __nfs_revalidate_inode.

    So it is definitely the consistent thing to do.

    Eric


    \
     
     \ /
      Last update: 2009-11-04 21:53    [W:0.022 / U:1.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site