Messages in this thread | | | From | (Eric W. Biederman) | Date | Wed, 04 Nov 2009 12:51:03 -0800 | Subject | Re: [PATCH 15/13] sysfs: Protect sysfs_refresh_inode with inode mutex. |
| |
"Serge E. Hallyn" <serue@us.ibm.com> writes:
> Quoting Eric W. Biederman (ebiederm@xmission.com): >> >> In general everything that writes to vfs inodes holds the >> inode mutex, so hold the inode mutex over sysfs_refresh_inode. >> The sysfs data structures don't need this but it looks like the >> vfs might. >> >> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com> > > Oh right so pls disregard my last reply to patch 9 :)
I also checked and nfs has the same basic structure and does take the inode mutex on these paths, inside of nfs_refresh_inode which is called from __nfs_revalidate_inode.
So it is definitely the consistent thing to do.
Eric
| |