Messages in this thread | | | Date | Wed, 4 Nov 2009 08:51:52 +0100 | From | Jens Axboe <> | Subject | Re: Fwd: [PATCH 0/5] cfq-iosched: improve latency for no-idle queues (v3) |
| |
On Tue, Nov 03 2009, Jeff Moyer wrote: > Jens Axboe <jens.axboe@oracle.com> writes: > > > On Tue, Nov 03 2009, Jeff Moyer wrote: > >> Jens Axboe <jens.axboe@oracle.com> writes: > >> > >> > Since for-linus contains conflicting changes, can you and Jeff please > >> > double check that everything is still in order? The interesting bit here > >> > is the merge with for-2.6.33 and the coop limit from Shaohua Li. I did > >> > the straight forward merge, but we likely just need to drop that logic > >> > since the coop concept is radically different given that we merge and > >> > break queues in for-2.6.33. > >> > >> Yeah, since I changed the meaning of the cfqq_coop flag, a lot of those > >> tests are just plain wrong. Let me play with it and I'll send you an > >> incremental patch in a bit. > > > > Thanks, here's what I have. It's basically a revert of the commit in > > question. > > Your patch looks like a straight-forward revert. I still think we need > some guards in place, though. For now, I think we can go with what you > have, and I'll come up with some other mechanism to deal with this case.
Thanks Jeff, I'll merge it up and we can get things straightened out in due time.
-- Jens Axboe
| |