Messages in this thread | | | Date | Wed, 04 Nov 2009 04:41:16 -0800 (PST) | Subject | Re: [Patch] net: fix incorrect counting in __scm_destroy() | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Wed, 04 Nov 2009 11:29:05 +0100
> Given we kfree(fpl) at the end of loop, we cannot recursively call > __scm_destroy() on same fpl, it would be a bug anyway ? > > So you probably need something better, like testing fpl->list being > not re-included in current->scm_work_list before kfree() it
I can't even see what the problem is.
The code is designed such that the ->count only matters for the top level.
If we recursively fput() and get back here, we'll see that there is someone higher in the call chain already running the fput() loop and we'll just list_add_tail().
The inner while() loop will make sure we process such entries once we get back to the top level and exit the for() loop.
Amerigo, please show us the problematic code path where the counts go wrong and this causes problems.
Thanks.
| |