lkml.org 
[lkml]   [2009]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 14/13] sysfs: sysfs_setattr remove unnecessary permission check.
    From
    Date

    inode_change_ok already clears the SGID bit when necessary so there is
    no reason for sysfs_setattr to carry code to do the same, and it is
    good to kill the extra copy because when I moved the code, I goofed
    and in certain corner cases the code will look at the wrong gid.

    Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
    ---
    fs/sysfs/inode.c | 4 ----
    1 files changed, 0 insertions(+), 4 deletions(-)

    diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
    index 72e2e99..e2595a7 100644
    --- a/fs/sysfs/inode.c
    +++ b/fs/sysfs/inode.c
    @@ -120,10 +120,6 @@ int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
    return error;

    iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */
    - if (iattr->ia_valid & ATTR_MODE) {
    - if (!in_group_p(inode->i_gid) && !capable(CAP_FSETID))
    - iattr->ia_mode &= ~S_ISGID;
    - }

    error = inode_setattr(inode, iattr);
    if (error)
    --
    1.6.5.2.143.g8cc62


    \
     
     \ /
      Last update: 2009-11-04 13:07    [W:0.024 / U:30.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site