Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/9] ksm: let shared pages be swappable | Date | Tue, 1 Dec 2009 13:14:20 +0900 (JST) |
| |
> > btw, I'm not sure why bellow kmem_cache_zalloc() is necessary. Why can't we > > use stack? > > Well, I didn't use stack: partly because I'm so ashamed of the pseudo-vmas > on the stack in mm/shmem.c, which have put shmem_getpage() into reports > of high stack users (I've unfinished patches to deal with that); and > partly because page_referenced_ksm() and try_to_unmap_ksm() are on > the page reclaim path, maybe way down deep on a very deep stack. > > But it's not something you or I should be worrying about: as the comment > says, this is just a temporary hack, to present a patch which gets KSM > swapping working in an understandable way, while leaving some corrections > and refinements to subsequent patches. This pseudo-vma is removed in the > very next patch.
I see. thanks for kindly explanation :)
| |