Messages in this thread | | | Subject | Re: [PATCH] PCI: Always set prefetchable base/limit upper32 registers | From | Alex Williamson <> | Date | Mon, 30 Nov 2009 14:43:57 -0700 |
| |
On Mon, 2009-11-30 at 14:42 -0700, Grant Grundler wrote: > On Mon, Nov 30, 2009 at 02:22:53PM -0700, Alex Williamson wrote: > > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c > > index cb1a027..127d759 100644 > > --- a/drivers/pci/setup-bus.c > > +++ b/drivers/pci/setup-bus.c > > @@ -221,11 +221,9 @@ static void pci_setup_bridge(struct pci_bus *bus) > > } > > pci_write_config_dword(bridge, PCI_PREF_MEMORY_BASE, l); > > > > - if (pref_mem64) { > > - /* Set the upper 32 bits of PREF base & limit. */ > > - pci_write_config_dword(bridge, PCI_PREF_BASE_UPPER32, bu); > > - pci_write_config_dword(bridge, PCI_PREF_LIMIT_UPPER32, lu); > > - } > > Why not remove all references to pref_mem64? > This was the only use AFAICT.
Ah, good point, I'll send a v2. Thanks Grant.
Alex
| |