lkml.org 
[lkml]   [2009]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/02] clocksource: Start CMT at clocksource resume
From
Hi Thomas,

On Sat, Nov 28, 2009 at 11:00 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 25 Nov 2009, Magnus Damm wrote:
>
>> From: Magnus Damm <damm@opensource.se>
>>
>> Add code to start the CMT timer on clocksource resume.
>>
>> This makes sure the timer is started during sysdev_resume().
>> Without this patch the clocksource may be read as suspended,
>> this after sysdev resume but before platform device resume.
>
> Hmm, don't you have the same situation on suspend ?
>
> platform device suspend stops the clock, but the generic code expects
> it to be running until sysdev shutdown.

You are correct, the same situation exists on suspend.

> Another thing is that you now run both, the sysdev and the platform
> resume. Is that by design or accident ?

By incorrect design. =)

To fix this properly I was thinking of adding a clocksource suspend()
callback and ditch the platform ops all together. If you don't mind
then I'll post a patch for that tomorrow!

Thank you!

/ magnus


\
 
 \ /
  Last update: 2009-11-30 12:21    [W:0.127 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site