lkml.org 
[lkml]   [2009]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] percpu: remove two suspicious break statements
On 11/30/2009 06:12 PM, Amerigo Wang wrote:
> These two break statements seem to be very suspicious,
> they are at the end of the statements inside the loop.
> Remove them.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: Tejun Heo <tj@kernel.org>

That actually is correct code. It's checking whether the first
iteration covers the whole thing. I thought the comment there

/* quick path, check whether all pages are already there */

explained it but looking at it again, it definitely isn't enough
unless you already know what's going on there. Can you please post a
patch to add the comment?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-11-30 12:13    [W:0.052 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site