lkml.org 
[lkml]   [2009]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH/RFC v5 4/5]: core: Add dump device to call on oopses and panics
From
Date
On Mon, 2009-11-30 at 10:23 +0000, David Woodhouse wrote:
> + /* Theoretically, the log could move on after we do this, but
> + there's not a log we can do about that. The new messages
> + will overwrite the start of what we dump. */
> + spin_lock_irqsave(&logbuf_lock, flags);
> + end = log_end & LOG_BUF_MASK;
> + chars = logged_chars;
> + spin_unlock_irqrestore(&logbuf_lock, flags);

Actually that's not true -- we _could_ hold the logbuf_lock until the
end of the function. Not entirely sure we _want_ to though...

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation



\
 
 \ /
  Last update: 2009-11-30 11:29    [W:0.153 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site