Messages in this thread | | | Date | Mon, 30 Nov 2009 09:55:42 +0000 | From | Ian Molton <> | Subject | Re: [PATCH 2/2] virtio: Convert virtio-rng to the new API |
| |
Rusty Russell wrote: > On Thu, 26 Nov 2009 10:55:27 am Ian Molton wrote: >> This patch converts virtio-rng to the new hw_rng API. >> >> In the process it fixes a previously untriggered buffering bug where the >> buffer is not drained correctly if it has a non-multiple-of-4 length. > > Hi Ian,
Hi!
> Looks good. Minor comments below: > >> @@ -16,6 +16,7 @@ >> * along with this program; if not, write to the Free Software >> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >> */ >> + >> #include <linux/err.h> >> #include <linux/hw_random.h> >> #include <linux/scatterlist.h> > > Gratuitous hunk?
Didn't look right without a gap :)
>> -static unsigned int data_left; >> +static unsigned int data_avail; >> static DECLARE_COMPLETION(have_data); >> +static int busy; > > I prefer bool and true/false for booleans these days.
I was wondering what the current opinion was on that one. I have to say I prefer it too, so I'll change that.
>> + >> +/* The host will fill any buffer we give it with sweet, sweet randomness. */ > > This comment belongs above register_buffer() now I think.
Yeah, didnt wanna make too much fus over it though. I'll move it too then :-)
> (But I'm glad you kept it!)
I think a sense of humour is important ;-)
Patch to follow.
-Ian
| |