lkml.org 
[lkml]   [2009]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/41] VFS: Make lookup_hash() return a struct path
In message <1256152779-10054-4-git-send-email-vaurora@redhat.com>, Valerie Aurora writes:

> @@ -1937,7 +1942,8 @@ EXPORT_SYMBOL(filp_open);
> */
> struct dentry *lookup_create(struct nameidata *nd, int is_dir)
> {
> - struct dentry *dentry = ERR_PTR(-EEXIST);
> + struct path path = { .dentry = ERR_PTR(-EEXIST) } ;

I assume the compiler will initialize path.mnt to NULL. Is NULL what you
want? Even if the compiler guarantees it, I think you should either
explicitly init .mnt to NULL or leave a comment explaining what's going on
-- so no future code reader will think that this was omitted; a comment can
clarify your intentions more explicitly.

A struct path often requires both .mnt and .dentry to be set; it's not like,
say, inode_operations, where clearly some fields can be initialized to NULL
just fine.

Erez.


\
 
 \ /
  Last update: 2009-11-30 07:07    [W:0.999 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site