lkml.org 
[lkml]   [2009]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] ftrace: Return EINVAL when writing invalid val to set_ftrace_filter
    Frederic Weisbecker wrote:
    > On Tue, Nov 03, 2009 at 08:56:28AM +0800, Li Zefan wrote:
    >> Currently it doesn't warn user on invald value:
    >>
    >> # echo nonexist_symbol > set_ftrace_filter
    >>
    >> Better make it return failure.
    >>
    >> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    >> ---
    >
    >
    > Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
    >
    > But shouldn't we have the same kind of check from
    > ftrace_match_module_records() if we haven't matched
    > anything with the regex?
    >

    Right, I overlooked it.



    \
     
     \ /
      Last update: 2009-11-04 04:01    [W:0.021 / U:31.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site