Messages in this thread |  | | | Date | Tue, 03 Nov 2009 16:17:53 -0500 | | From | Jeff Garzik <> | | Subject | Re: [PATCH 10/14] drivers/ata/libata: Move dereference after NULL test |
On 10/17/2009 02:41 AM, Julia Lawall wrote: > From: Julia Lawall<julia@diku.dk> > > In each case, if the NULL test on qc is needed, then the derefernce > should be after the NULL test. > > A simplified version of the semantic match that detects this problem is as > follows (http://coccinelle.lip6.fr/): > > //<smpl> > @match exists@ > expression x, E; > identifier fld; > @@ > > * x->fld > ... when != \(x = E\|&x\) > * x == NULL > //</smpl> > > Signed-off-by: Julia Lawall<julia@diku.dk>
applied
|  |