lkml.org 
[lkml]   [2009]   [Nov]   [3]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 3 Nov 2009 21:29:24 +0100
FromFrederic Weisbecker <>
SubjectRe: [PATCH 4/6] hw-breakpoints: Rewrite the hw-breakpoints layer on top of perf events
On Tue, Nov 03, 2009 at 09:22:04PM +0100, Jan Kiszka wrote:
> > Thinking about it, this check should cover every cases:
> >
> > if (vcpu->arch.switch_db_regs || __get_cpu_var(dr7) & DR_GLOBAL_ENABLE_MASK)
> >
> > If we have __get_cpu_var(dr7) & DR_GLOBAL_ENABLE_MASK, it means there is an
> > active breakpoint and then we should restore the current state.
> >
>
> And what about (__get_cpu_var(dr7) & DR_GLOBAL_ENABLE_MASK) only? Would
> you be able to live with unsync'ed hardware and software states?
>
> Jan
>


But if the guest has breakpoints activated, the host will inherit
them, which is really not something we want, assuming vcpu->arch.switch_db_regs
already protects us about that.



\
 
 \ /
  Last update: 2009-11-03 21:31    [W:0.263 / U:0.090 seconds]
©2003-2009 Jasper Spaans