lkml.org 
[lkml]   [2009]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: kernel building regression on 32-rc5 kernel
    On Tue, Nov 03 2009, Shi, Alex wrote:
    > I found the kernel building will have about 20%~ 30% regressions on
    > our NHM machines. My kernel build do the following things 15 times:
    >
    > make mrproper; echo \"3\">/proc/sys/vm/drop_caches; make defconfig;
    > make -j${2timescpunumbers}
    >
    >
    >
    > Bisect found it is due to the commitment:
    >
    > commit a6151c3a5c8e1ff5a28450bc8d6a99a2a0add0a7

    I looked over that commit and found one typo, can you check with this
    patch applied?

    diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
    index 069a610..5802e32 100644
    --- a/block/cfq-iosched.c
    +++ b/block/cfq-iosched.c
    @@ -2051,7 +2051,7 @@ cfq_should_preempt(struct cfq_data *cfqd, struct cfq_queue *new_cfqq,
    * it's a metadata request and the current queue is doing regular IO.
    */
    if (rq_is_meta(rq) && !cfqq->meta_pending)
    - return false;
    + return true;

    /*
    * Allow an RT request to pre-empt an ongoing non-RT cfqq timeslice.
    --
    Jens Axboe



    \
     
     \ /
      Last update: 2009-11-03 19:35    [W:0.027 / U:124.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site