lkml.org 
[lkml]   [2009]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH v2 0/3] DRM/KMS framebuffer fixes
    James Simmons wrote:
    >> Without an allocated colormap, FBIOGETCMAP fails. This would make
    >> programs restore an all-black colormap ("links -g") or fail to work
    >> altogether ("mplayer -vo fbdev2").
    >>
    >> --- linux-2.6/drivers/gpu/drm/i915/intel_fb.c
    >> +++ linux-2.6/drivers/gpu/drm/i915/intel_fb.c
    >> @@ -227,6 +227,10 @@ static int intelfb_create(struct drm_dev
    >>
    >> fb->fbdev = info;
    >>
    >> + ret = fb_alloc_cmap(&info->cmap, 256, 0);
    >> + if (ret)
    >> + goto out_unpin;
    >> +
    >> par->intel_fb = intel_fb;
    >
    > It would be better to place that code in drm_fb_helper_single_fb_probe.

    Thanks, I wasn't quite able to untangle the indirections between the
    four framebuffer structures.

    New patch set follows.


    \
     
     \ /
      Last update: 2009-11-03 13:21    [W:0.022 / U:31.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site