Messages in this thread |  | | | Date | Tue, 03 Nov 2009 13:17:54 +0100 | | From | Clemens Ladisch <> | | Subject | [PATCH v2 0/3] DRM/KMS framebuffer fixes |
| |
James Simmons wrote: >> Without an allocated colormap, FBIOGETCMAP fails. This would make >> programs restore an all-black colormap ("links -g") or fail to work >> altogether ("mplayer -vo fbdev2"). >> >> --- linux-2.6/drivers/gpu/drm/i915/intel_fb.c >> +++ linux-2.6/drivers/gpu/drm/i915/intel_fb.c >> @@ -227,6 +227,10 @@ static int intelfb_create(struct drm_dev >> >> fb->fbdev = info; >> >> + ret = fb_alloc_cmap(&info->cmap, 256, 0); >> + if (ret) >> + goto out_unpin; >> + >> par->intel_fb = intel_fb; > > It would be better to place that code in drm_fb_helper_single_fb_probe.
Thanks, I wasn't quite able to untangle the indirections between the four framebuffer structures.
New patch set follows.
|  |