lkml.org 
[lkml]   [2009]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: tulip : kernel BUG in tulip_up/tulip_resume
Philippe De Muyter wrote, On 11/08/2009 11:33 PM:

> Hello,
>
> I have just installed 2.6.31 (from opensuse 11.2) one a tulip-equipped
> computer and I get the following error message from the kernel :
>
> [ 2495.526390] ------------[ cut here ]------------
> [ 2495.526390] kernel BUG at /usr/src/packages/BUILD/kernel-default-2.6.31.5/linux-2.6.31/include/linux/netdevice.h:439!
> [ 2495.526390] invalid opcode: 0000 [#1] SMP
...
> This comes from a BUG_ON in napi_enable in netdevice.h.
>
> napi_enable itself is called by tulip_up as such :
>
> #ifdef CONFIG_TULIP_NAPI
> napi_enable(&tp->napi);
> #endif
>
> At first reading, a matching napi_disable is called in tulip_down.
>
> Does someone know what could be wrong and have a fix or should I look myself ?

Don't know, guess only...

Jarek P.
---

drivers/net/tulip/tulip_core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 0df983b..6b1456c 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1787,11 +1787,11 @@ static int tulip_resume(struct pci_dev *pdev)
return retval;
}

- netif_device_attach(dev);
-
if (netif_running(dev))
tulip_up(dev);

+ netif_device_attach(dev);
+
return 0;
}


\
 
 \ /
  Last update: 2009-11-29 01:19    [W:0.090 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site