lkml.org 
[lkml]   [2009]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateFri, 27 Nov 2009 07:13:19 +0100
FromIngo Molnar <>
SubjectRe: [PATCH 1/4 tip/sched/core] sched: rename preempt_notifier to sched_notifier and always enable it

* Tejun Heo <tj@kernel.org> wrote:

> Hello,
>
> 11/27/2009 02:46 PM, Ingo Molnar wrote:
> > Other code will benefit from it though, such as the page fault callbacks
> > i already mentioned.
> >
> > My position on this is rather clear: i want no new callbacks and no
> > changes to callbacks in the scheduler until this situation is cleaned
> > up. Five callback sites are _way_ too much - so if you want to add
> > callbacks or change them, please clean it up and improve it first.
>
> Even changes which cause no functional differences? [...]

Such as enabling preempt notifiers unconditionally? That's a functional
change - it turns a so-far optional callback into an essentially
mandatory one.

Ingo


\
 
 \ /
  Last update: 2009-11-27 07:17    [from the cache]
©2003-2010