lkml.org 
[lkml]   [2009]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/3] netdevice: provide common routine for macvlan and vlan operstate management
    Date
    On Friday 13 November 2009, Patrick Mullaney wrote:
    > @@ -551,7 +532,7 @@ static int macvlan_newlink(struct net_device *dev,
    > return err;
    >
    > list_add_tail(&vlan->list, &port->vlans);
    > - macvlan_transfer_operstate(dev);
    > + netif_stacked_transfer_operstate(dev, lowerdev);
    > return 0;
    > }
    >
    > @@ -591,7 +572,8 @@ static int macvlan_device_event(struct notifier_block *unused,
    > switch (event) {
    > case NETDEV_CHANGE:
    > list_for_each_entry(vlan, &port->vlans, list)
    > - macvlan_transfer_operstate(vlan->dev);
    > + netif_stacked_transfer_operstate(vlan->dev,
    > + vlan->lowerdev);
    > break;
    > case NETDEV_FEAT_CHANGE:
    > list_for_each_entry(vlan, &port->vlans, list) {

    These have the arguments reversed, lowerdev should come first.

    Arnd <><


    \
     
     \ /
      Last update: 2009-11-27 14:13    [W:0.020 / U:0.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site