Messages in this thread | | | Date | Thu, 26 Nov 2009 09:14:09 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] cfq: Make use of service count to estimate the rb_key offset |
| |
On Thu, Nov 26 2009, Gui Jianfeng wrote: > Hi Jens, Czoccolo > > For the moment, different workload cfq queues are put into different > service trees. But CFQ still uses "busy_queues" to estimate rb_key > offset when inserting a cfq queue into a service tree. I think this > isn't appropriate, and it should make use of service tree count to do > this estimation. This patch is for for-2.6.33 branch.
Makes sense, we've before discussed that using ->busy_queues isn't very good, as it's not a stable count. service_tree count isn't that much better, but for for-2.6.33 it does make more sense.
-- Jens Axboe
| |