Messages in this thread | | | Date | Thu, 26 Nov 2009 12:15:23 +0100 | From | Michal Marek <> | Subject | Re: [PATCH] kconfig: display an error message when aborting |
| |
On 25.11.2009 05:48, Mike Frysinger wrote: > If the Kconfig option causes an open() failure (like one that starts with > an underscore), there should be an error message shown since we're going > to be exiting with an error code. Otherwise, the reason for the failure > can really only be diagnosed with strace or something similar. > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > --- > scripts/kconfig/confdata.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > index b55e72f..e2644b4 100644 > --- a/scripts/kconfig/confdata.c > +++ b/scripts/kconfig/confdata.c > @@ -640,6 +640,8 @@ static int conf_split_config(void) > fd = open(path, O_WRONLY | O_CREAT | O_TRUNC, 0644); > if (fd == -1) { > if (errno != ENOENT) { > + conf_warning("sym '%s' with path '%s': %s", > + sym->name, path, strerror(errno)); > res = 1; > break; > }
I agree that there definitely needs to be some error reporting (and not only here but in many more places, look e.g. at conf_write() or conf_write_autoconf()), but why use conf_warning() for this? It will prefix the error message with "include/config/auto.conf:<last lineno>", which has nothing to do with the path that could not be opened.
Michal
| |