lkml.org 
[lkml]   [2009]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vmscan: do not evict inactive pages when skipping an active list scan
On 11/25/2009 09:50 PM, KOSAKI Motohiro wrote:
>
>> - if (lru == LRU_ACTIVE_ANON&& inactive_anon_is_low(zone, sc)) {
>> - shrink_active_list(nr_to_scan, zone, sc, priority, file);
>> + if (lru == LRU_ACTIVE_ANON) {
>> + if (inactive_file_is_low(zone, sc))
>>
> This inactive_file_is_low() should be inactive_anon_is_low().
> cut-n-paste programming often makes similar mistake. probaby we need make
> more cleanup to this function.
>
> How about this? (this is incremental patch from you)
>
>
>
Doh! Nice catch...
> Signed-off-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
>
>
Reviewed-by: Rik van Riel <riel@redhat.com>


\
 
 \ /
  Last update: 2009-11-26 04:01    [W:0.167 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site