Messages in this thread | | | Date | Wed, 25 Nov 2009 21:57:47 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH] vmscan: do not evict inactive pages when skipping an active list scan |
| |
On 11/25/2009 09:50 PM, KOSAKI Motohiro wrote: > >> - if (lru == LRU_ACTIVE_ANON&& inactive_anon_is_low(zone, sc)) { >> - shrink_active_list(nr_to_scan, zone, sc, priority, file); >> + if (lru == LRU_ACTIVE_ANON) { >> + if (inactive_file_is_low(zone, sc)) >> > This inactive_file_is_low() should be inactive_anon_is_low(). > cut-n-paste programming often makes similar mistake. probaby we need make > more cleanup to this function. > > How about this? (this is incremental patch from you) > > > Doh! Nice catch... > Signed-off-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > > Reviewed-by: Rik van Riel <riel@redhat.com>
| |