lkml.org 
[lkml]   [2009]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 35/86] pata_it8213: fix UDMA handling
    From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Subject: [PATCH] pata_it8213: fix UDMA handling

    Driver should program the cycle timing not the mode number
    (doing the latter results in wrong timings being used).

    There shouldn't be any problems with it as IDE it8213 host driver
    has been doing it this way for years.

    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    ---
    drivers/ata/pata_it8213.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    Index: b/drivers/ata/pata_it8213.c
    ===================================================================
    --- a/drivers/ata/pata_it8213.c
    +++ b/drivers/ata/pata_it8213.c
    @@ -173,10 +173,10 @@ static void it8213_set_dmamode (struct a

    udma_enable |= (1 << devid);

    - /* Load the UDMA mode number */
    + /* Load the UDMA cycle time */
    pci_read_config_word(dev, 0x4A, &udma_timing);
    udma_timing &= ~(3 << (4 * devid));
    - udma_timing |= (udma & 3) << (4 * devid);
    + udma_timing |= u_speed << (4 * devid);
    pci_write_config_word(dev, 0x4A, udma_timing);

    /* Load the clock selection */

    \
     
     \ /
      Last update: 2009-11-25 18:19    [W:2.810 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site