| | From | Bartlomiej Zolnierkiewicz <> | | Subject | Re: [PATCH 02/38] move atp870u_remove to .devexit.text | | Date | Wed, 25 Nov 2009 14:38:24 +0100 |
| |
On Tuesday 24 November 2009 10:38:16 pm James Bottomley wrote: > On Tue, 2009-11-24 at 22:06 +0100, Uwe Kleine-König wrote: > > The function atp870u_remove is used only wrapped by __devexit_p so define > > it using __devexit. > > But there's really no point to this. HOTPLUG is always defined on SCSI > systems that have these drivers, which means that _devinit/exit are > nops. That makes the change purely cosmetic and not worth churning two > dozen drivers for.
Looking at things from a bit different angle:
These tags still have some value as a documentation and help in maintaining some level of the coherency between different parts of a kernel (which is a Good Thing).
-- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|