Messages in this thread | | | Date | Tue, 24 Nov 2009 12:29:37 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] gpio: Langwell GPIO driver miscellaneous clean-ups |
| |
On Sun, 22 Nov 2009 11:19:01 +0800 Alek Du <alek.du@intel.com> wrote:
> >From 9ba8224f5246ef7fdf1c0a15bb5535e442731435 Mon Sep 17 00:00:00 2001 > From: Alek Du <alek.du@intel.com> > Date: Sun, 22 Nov 2009 10:58:21 +0800 > Subject: [PATCH] gpio: Langwell GPIO driver miscellaneous clean-ups > > 1. Use >= N to check invalid gpio number (unsigned type)
I already had this in gpio-fix-test-on-unsigned-in-lnw_irq_type.patch
> 2. Remove wrong and unnecessary unmask operation > 3. Remove extra GEDR reading > > The 2) and 3) will fix interrupts losing when two or more pins are triggered at close time. >
Those aren't cleanups - they're bug fixes!
How important are they?
| |