lkml.org 
[lkml]   [2009]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [stable] [PATCH] serial: 8250: Add ns16550a to OF compatible list
On Tue, Nov 24, 2009 at 09:53:52AM +0000, Arnd Bergmann wrote:
> On Tuesday 24 November 2009 09:21:42 monstr@monstr.eu wrote:
> > From: Michal Simek <monstr@monstr.eu>
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> I was holding off on that patch to make sure the discussion had ended,
> but this part certainly looks good.
>
> Some points on form though:
>
> * The patch is missing a changelog, which is always required, but especially
> important if you're changing code that you want in -stable!
>
> * You did not cc me. Ok, I just noticed I'm missing an entry in the MAINTAINERS
> file, but scripts/get_maintainer.pl would have given you a good indication of
> who feels responsible. You also didn't cc Alon, who submitted a similar patch
> [1] just days ago, which I assume prompted you to send this. If you didn't see
> his patch, nevermind.
>
> * Patches go into mainline first, then into stable [2]. Asking for inclusion into
> -stable for a patch that is still being discussed for inclusion in -next is
> the wrong order, no matter how obvious and trivial the patch is.

The easiest way to do this is to add:
cc: stable <stable@kernel.org>
to the signed-off-by area of the patch. Then, when it goes into Linus's
tree the stable developers will be automatically notified of it and suck
it into their tree as well, no additional work needs to be done by you
at all.

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-11-24 15:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site