Messages in this thread Patch in this message | | | Date | Tue, 24 Nov 2009 21:47:54 +0800 | From | "Liuweni" <> | Subject | [PATCH]irq/core:Add a length limitation |
| |
In the register_handler_proc(), the max length of irqaction->name is MAX_NAMELEN. And this function will call name_unique() to compare name with other irqs'. There is no any code for limitation the length. I add a warning in the function to notice that the irqaction->name is too long.
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com> --- diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index 0832145..9ab6e04 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -196,6 +196,9 @@ void register_handler_proc(unsigned int irq, struct irqaction *action) char name [MAX_NAMELEN]; struct irq_desc *desc = irq_to_desc(irq); + if(strlen(action->name) >= MAX_NAMELEN) + WARN_ON(1); + if (!desc->dir || action->dir || !action->name || !name_unique(irq, action)) return; --- Best Regards, Liuweni 2009-11-24
| |