Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 1/2] pata_hpt37x: add proper cable detection methods | Date | Mon, 23 Nov 2009 21:07:22 +0100 |
| |
On Monday 23 November 2009 08:42:23 pm Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > --- > > drivers/ata/pata_hpt37x.c | 86 +++++++++++++++++++++++++++++----------------- > > 1 file changed, 56 insertions(+), 30 deletions(-) > > > Index: b/drivers/ata/pata_hpt37x.c > > =================================================================== > > --- a/drivers/ata/pata_hpt37x.c > > +++ b/drivers/ata/pata_hpt37x.c > > @@ -303,6 +303,59 @@ static unsigned long hpt370a_filter(stru > > As this driver still carries a version info, don't we need to update it?
While doing the previously mentioned PATA rework I've looked at the ratio of patches actually updating version numbers and not doing so. This lead me to the same conclusions as with version numbers in IDE drivers previously..
However this is just my opinion so if you for some reason would like to bump version numbers of some drivers I won't complain..
-- Bartlomiej Zolnierkiewicz
| |