Messages in this thread |  | | | Subject | RE: drivers/ide/au1xxx-ide.c: use resource_size() | | Date | Mon, 23 Nov 2009 13:37:05 -0500 | | From | "H Hartley Sweeten" <> |
| |
On Monday, November 23, 2009 11:28 AM, David Miller wrote: > From: "H Hartley Sweeten" <hartleys@visionengravers.com> > Date: Mon, 23 Nov 2009 13:15:32 -0500 > >> Use resource_size() for {request/release}_mem_region and ioremap. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > > Applied to ide-next-2.6, thanks. > >> >> - ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1); >> + ahwif->regbase = (u32)ioremap(res->start, resource_size(res)); >> if (ahwif->regbase == 0) { >> ret = -ENOMEM; >> goto out; > > That needs some fixing. ioremap()'s return value is an > "__iomem" pointer, not an integer. ->regbase's type should be > changed to something like "void __iomem *" etc.
Agree. But that was already in the driver.
I don't have to hardware to test this so I didn't want to dig to deeply into fixing that.
Thanks, Hartley
|  |