lkml.org 
[lkml]   [2009]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: drivers/ide/au1xxx-ide.c: use resource_size()
Date
From
On Monday, November 23, 2009 11:28 AM, David Miller wrote:
> From: "H Hartley Sweeten" <hartleys@visionengravers.com>
> Date: Mon, 23 Nov 2009 13:15:32 -0500
>
>> Use resource_size() for {request/release}_mem_region and ioremap.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> Applied to ide-next-2.6, thanks.
>
>>
>> - ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1);
>> + ahwif->regbase = (u32)ioremap(res->start, resource_size(res));
>> if (ahwif->regbase == 0) {
>> ret = -ENOMEM;
>> goto out;
>
> That needs some fixing. ioremap()'s return value is an
> "__iomem" pointer, not an integer. ->regbase's type should be
> changed to something like "void __iomem *" etc.

Agree. But that was already in the driver.

I don't have to hardware to test this so I didn't want to dig to deeply
into fixing that.

Thanks,
Hartley


\
 
 \ /
  Last update: 2009-11-23 19:39    [from the cache]
©2003-2011 Jasper Spaans