lkml.org 
[lkml]   [2009]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86: crash kernel reserve with reserve_early -v2
Yinghai Lu <yinghai@kernel.org> writes:

> Eric W. Biederman wrote:
>> Yinghai Lu <yinghai@kernel.org> writes:
>>
>>> use find_e820_area/reserve_early instead.
>>>
>>> -v2: address Eric's request, to restore original semantics.
>>> will fail, if the provided address can not be used.
>>
>> This patch seems reasonable.
>>
>> YH what is the benefit of using reserve_early, and moving
>> reserve_crashkernel earlier?
>
> old way mixing find_e820_area and reserve_bootmem like bandit...

Sounds like bitrot of the best practices.

> also there are some effects to remove bootmem, so we try to reduce bootmem reference.

Makes sense. Extent based allocators early allocators are much more efficient.

Eric


\
 
 \ /
  Last update: 2009-11-23 06:15    [W:1.095 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site