Messages in this thread |  | | | Date | Mon, 23 Nov 2009 13:17:44 +0200 | | From | Dan Carpenter <> | | Subject | Re: [PATCH 5/17] [LogFS] dir.c |
| |
On Fri, Nov 20, 2009 at 08:37:29PM +0100, Joern Engel wrote: > +static int logfs_unlink(struct inode *dir, struct dentry *dentry) > +{ > + struct logfs_super *super = logfs_super(dir->i_sb); > + struct inode *inode = dentry->d_inode; > + struct logfs_transaction *ta; > + struct page *page; > + pgoff_t index; > + int ret; > + > + ta = kzalloc(sizeof(*ta), GFP_KERNEL); > + if (!ta) > + return -ENOMEM; > + > + ta->state = UNLINK_1; > + ta->ino = inode->i_ino; > + > + inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME; > + > + page = logfs_get_dd_page(dir, dentry); > + if (!page)
kfree(ta);
> + return -ENOENT; > + if (IS_ERR(page))
kfree(ta);
> + return PTR_ERR(page);
regards, dan carpenter
|  |