lkml.org 
[lkml]   [2009]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] viafb: Use sizeof struct rather than pointer
    The returned error should be negative

    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    ---
    drivers/video/via/viafbdev.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    > Unless I am mistaken?

    There was another in the same file:

    diff --git a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
    index 56ec696..7b181e7 100644
    --- a/drivers/video/via/viafbdev.c
    +++ b/drivers/video/via/viafbdev.c
    @@ -680,7 +680,7 @@ static int viafb_ioctl(struct fb_info *info, u_int cmd, u_long arg)
    if (!viafb_gamma_table)
    return -ENOMEM;
    if (copy_from_user(viafb_gamma_table, argp,
    - sizeof(viafb_gamma_table))) {
    + sizeof(*viafb_gamma_table))) {
    kfree(viafb_gamma_table);
    return -EFAULT;
    }
    @@ -694,7 +694,7 @@ static int viafb_ioctl(struct fb_info *info, u_int cmd, u_long arg)
    return -ENOMEM;
    viafb_get_gamma_table(viafb_gamma_table);
    if (copy_to_user(argp, viafb_gamma_table,
    - sizeof(viafb_gamma_table))) {
    + sizeof(*viafb_gamma_table))) {
    kfree(viafb_gamma_table);
    return -EFAULT;
    }

    \
     
     \ /
      Last update: 2009-11-21 19:53    [W:0.041 / U:8.360 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site