Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 4/5] pata: Update experimental tags | Date | Fri, 20 Nov 2009 22:17:31 +0100 |
| |
On Thursday 19 November 2009 11:03:29 pm Jeff Garzik wrote: > On 11/19/2009 04:49 PM, Bartlomiej Zolnierkiewicz wrote:
> >> Absent stronger justification, libata remains with separate drivers, > >> even if that means some code duplication. > > > > I can always hold my own tree with such changes if needed. > > If it really bugs you, you could take the drivers/ata/sata_promise.h > approach, or do multi-file modules.
One of the main problems with separate drivers is a needless complexity of the detection logic (different chips share same PCI IDs) and relevant code parts presenting the issue were already posted in this thread.
PS It would bug me really if I were the author or the maintainer of said code but since I'm not I'll get to fixing it only when I'm bored enough..
-- Bartlomiej Zolnierkiewicz
| |