Messages in this thread | | | Date | Fri, 20 Nov 2009 17:09:06 +0000 | From | Jamie Lokier <> | Subject | Re: [PATCH 02/15] osst: Use noop_llseek() instead of default_llseek() |
| |
Jan Blunck wrote: > __os_scsi_tape_open() suggests that llseek() doesn't work: > "We really want to do nonseekable_open(inode, filp); here, but some > versions of tar incorrectly call lseek on tapes and bail out if that > fails. So we disallow pread() and pwrite(), but permit lseeks." > > Instead of using the fallback default_llseek() the driver should use > noop_llseek() which leaves the file->f_pos untouched but succeeds.
st.c has the same comment, but I didn't see a patch for st.c in the series.
-- Jamie
| |