lkml.org 
[lkml]   [2009]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/entry] x86: Fix user return notifier put_cpu_var() invocation
    Commit-ID:  3c912b6edaac56cb451e7571c95c15cbb6bd0c81
    Gitweb: http://git.kernel.org/tip/3c912b6edaac56cb451e7571c95c15cbb6bd0c81
    Author: Stephen Rothwell <sfr@canb.auug.org.au>
    AuthorDate: Mon, 2 Nov 2009 16:17:22 +1100
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Mon, 2 Nov 2009 07:58:59 +0100

    x86: Fix user return notifier put_cpu_var() invocation

    Today's linux-next build (x86_64 allmodconfig) failed like this:

    kernel/user-return-notifier.c: In function
    'fire_user_return_notifiers': kernel/user-return-notifier.c:45:
    error: expected expression before ')' token

    Introduced by commit 7c68af6e32c73992bad24107311f3433c89016e2
    ("core, x86: Add user return notifiers") from the tip and kvm trees
    but revealed by commit e0fdb0e050eae331046385643618f12452aa7e73
    ("percpu: add __percpu for sparse") from the percpu tree.

    Before that percpu tree commit, "put_cpu_var()" would compile
    without error (even though it really needs a parameter).

    Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Cc: Avi Kivity <avi@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Cc: Christoph Lameter <cl@linux-foundation.org>
    LKML-Reference: <20091102161722.eea4358d.sfr@canb.auug.org.au>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    kernel/user-return-notifier.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/user-return-notifier.c b/kernel/user-return-notifier.c
    index 530ccb8..03e2d6f 100644
    --- a/kernel/user-return-notifier.c
    +++ b/kernel/user-return-notifier.c
    @@ -42,5 +42,5 @@ void fire_user_return_notifiers(void)
    head = &get_cpu_var(return_notifier_list);
    hlist_for_each_entry_safe(urn, tmp1, tmp2, head, link)
    urn->on_user_return(urn);
    - put_cpu_var();
    + put_cpu_var(return_notifier_list);
    }

    \
     
     \ /
      Last update: 2009-11-02 11:21    [W:0.022 / U:0.708 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site