Messages in this thread Patch in this message | | | Date | Tue, 03 Nov 2009 10:49:32 +0900 (JST) | Subject | [PATCH][RFC] Removing wrong judgement of checkpatch.pl for return as function | From | Hitoshi Mitake <> |
| |
Hi,
I found a strange behaviour of checkpatch.pl.
The C statement: return (type)value; is regarded as return like a function form by checkpatch.pl. So checkpatch.pl causes "Return is not a function." error when processing statements like this.
I think statements like above are innocence. These are only doing type cast. This patch removes the behaviour of checkpatch.pl.
But I don't have confidence about coding style of Linux kernel. Is my thought correct? Or the behaviour of current checkpatch.pl is correct? Request for comment.
Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
--- scripts/checkpatch.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bc4114f..04a876c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2117,7 +2117,7 @@ sub process { } # Return is not a function. - if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { + if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*)\);/s) { my $spacing = $1; my $value = $2; -- 1.5.6.5
| |