Messages in this thread | | | Date | Tue, 3 Nov 2009 08:34:16 +0900 | From | Minchan Kim <> | Subject | Re: [PATCHv2 1/5] vmscan: separate sc.swap_cluster_max and sc.nr_max_reclaim |
| |
On Tue, 3 Nov 2009 00:35:30 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> Hi > > > > @@ -1932,6 +1938,7 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order) > > > .may_unmap = 1, > > > .may_swap = 1, > > > > > .swap_cluster_max = SWAP_CLUSTER_MAX, > > Or add comment in here. > > > > 'kswapd doesn't want to be bailed out while reclaim.' > > OK, reasonable. > How about this? > > > > --- > mm/vmscan.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 7fb3435..84e4da0 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1930,6 +1930,10 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order) > .gfp_mask = GFP_KERNEL, > .may_unmap = 1, > .may_swap = 1, > + /* > + * kswapd doesn't want to be bailed out while reclaim. because > + * we want to put equal scanning pressure on each zone. > + */ > .nr_to_reclaim = ULONG_MAX, > .swappiness = vm_swappiness, > .order = order, > -- > 1.6.2.5 >
Reviewed-by: Minchan Kim <minchan.kim@gmail.com> It looks good than mine. Thanks, Kosaki. :)
-- Kind regards, Minchan Kim
| |