Messages in this thread | | | Date | Mon, 2 Nov 2009 21:12:34 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH v2 0/7] vsprintf: reduce code size and clean up |
| |
On Mon, Nov 02, 2009 at 03:26:07PM -0200, André Goddard Rosa wrote: > Subject: [PATCH v2 0/7] vsprintf: reduce code size and clean up > > This patch reduces code size by 240 bytes on my Core 2 with gcc 4.4.1: > text data bss dec hex filename > 15767 0 8 15775 3d9f lib/vsprintf.o-before > 15527 0 8 15535 3caf lib/vsprintf.o-after > > and implements some cleanups. > > Changelog: > v2: addressed feedback from Frederic Weisbecker review (thanks!!) > and split into separate patches > v1: original submission > > André Goddard Rosa (7): > vsprintf: factorize "(null)" string > vsprintf: pre-calculate final string length > vsprintf: give it some care to please checkpatch.pl > vsprintf: use TOLOWER whenever possible > vsprintf: reduce code size by avoiding extra check > vsprintf: move local vars to block local vars and remove unneeded > ones > vsprintf: factor out skip_space code in a separate function > > lib/vsprintf.c | 306 ++++++++++++++++++++++++++++++-------------------------- > 1 files changed, 163 insertions(+), 143 deletions(-)
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
But please add a more verbose changelog in the 5th as per Ingo's request, and do the case statement merge I suggested in the 6th.
Thanks!
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |