Messages in this thread | | | Date | Mon, 2 Nov 2009 12:10:20 -0500 | From | "John W. Linville" <> | Subject | Re: wpa2 hangs v2.6.32-rc5-402-gb6727b1. Revert 7d930bc33653d5592dc386a76a38f39c2e962344 fixed it. |
| |
On Mon, Nov 02, 2009 at 11:05:07PM +0800, Jeff Chua wrote: > On Mon, Nov 2, 2009 at 4:49 PM, Johannes Berg <johannes@sipsolutions.net>wrote: > > > On Sun, 2009-11-01 at 16:53 -0800, Linus Torvalds wrote: > > > That decodes to > > > cfg80211_conn_work+89: > > > ie it looks like 'conn->params.bssid' is NULL and we oops when we try to > > > load bssid from there. The code is: > > > memcpy(bssid, wdev->conn->params.bssid, ETH_ALEN); > > > And yes, that "memcpy()" was added in that buggy commit. > > > > Indeed, thank you. I'd analysed this before but not made the connection > > with Jeff's report. > > > > > So reverting 7d930bc33653d5592dc386a76a38f39c2e962344 is the correct > > thing > > > to do. Or somebody needs to fix that piece-of-shit code. > > > > Yes ... that params.bssid was != NULL was a bad assumption in that > > commit. The right thing to do is to add a check and pass NULL through, > > like I did here: > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/41695 > > > > That patch fixes the WPA2 hanging the system problem for me. > > Thanks for the quick responses!
I'll roll that up with a few other fixes and send it to Dave M. today.
John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.
| |