lkml.org 
[lkml]   [2009]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Mon, Nov 02, 2009 at 03:32:58PM +0100, Ingo Molnar wrote:
> >
> > Please use the standard construct and put an #ifndef __ASSEMBLY__ around
> > it.
>
> You mean like this?
>
> diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
> index 0b20bbb..e22d237 100644
> --- a/arch/x86/include/asm/i387.h
> +++ b/arch/x86/include/asm/i387.h
> @@ -10,6 +10,13 @@
> #ifndef _ASM_X86_I387_H
> #define _ASM_X86_I387_H
>
> +#ifdef __ASSEMBLY__
> +
> +#define PSHUFB_XMM5_XMM0 .byte 0x66, 0x0f, 0x38, 0x00, 0xc5
> +#define PSHUFB_XMM5_XMM6 .byte 0x66, 0x0f, 0x38, 0x00, 0xf5
> +
> +#else
> +
> #include <linux/sched.h>
> #include <linux/kernel_stat.h>
> #include <linux/regset.h>
> @@ -411,4 +418,5 @@ static inline unsigned short get_fpu_mxcsr(struct task_struct *tsk)
> }
> }
>
> +#endif /* __ASSEMBLY__ */
> #endif /* _ASM_X86_I387_H */

Yeah. Or just a single block of:


#ifndef __ASSEMBLY__
...
#endif /* __ASSEMBLY__ */

around the C bits - anything outside that is good for assembly as well.

Ingo


\
 
 \ /
  Last update: 2009-11-02 16:49    [W:0.597 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site