[lkml]   [2009]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Using statically allocated memory for platform_data.
    On Mon, Nov 02, 2009 at 03:00:11PM +0000, Ben Dooks wrote:
    > This looks like something is freeing stuff that it did not allocate in
    > the first place, which is IMHO bad. The call platform_device_alloc()
    > is setting platform_device_release() as the default release function
    > but platform_device_release() releases more than platform_device_alloc()
    > actually created.
    > My view is that platform_device_alloc()'s default release shouldn't
    > be freeing the platform data, and that using platform_device_add_data()
    > or platform_device_add_resources() should change either the behvaiour
    > of platform_device_release() or it should change the pointer to a new
    > release function.

    That doesn't work - how do those other functions (adding) know what data
    has also been added by other functions? That can't work reliably.

     \ /
      Last update: 2009-11-02 16:09    [W:0.025 / U:42.968 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site